routing: local balance check before path finding#3749
routing: local balance check before path finding#3749joostjager merged 7 commits intolightningnetwork:masterfrom
Conversation
joostjager
force-pushed
the
extended-routing-failures
branch
2 times, most recently
from
962616c to
7939a9d
Compare
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
nice commit structure, only question i have is whether or not to also begin exposing the tlv failures as a specific rpc destination failure rather than no route found. it's not super in line with this pr, so may be best in a follow up
joostjager
force-pushed
the
extended-routing-failures
branch
2 times, most recently
from
05ffb0f to
bbd7cd5
Compare
joostjager
added
v0.9.0
error messages
payments
joostjager
force-pushed
the
extended-routing-failures
branch
from
bbd7cd5 to
a57595b
Compare
|
Todo: add test |
joostjager
force-pushed
the
extended-routing-failures
branch
from
a57595b to
7f7cc1e
Compare
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Great work, the changes were very easy to follow.
This fix should really improve the UX of lnd, especially for beginners.
There are only two small things that should be fixed IMO, the rest is non-blocking.
joostjager
force-pushed
the
extended-routing-failures
branch
from
7f7cc1e to
32900ec
Compare
| // or payment attempt isn't known to be within the current version of | ||
| // the channel graph. | ||
| ErrTargetNotInNetwork | ||
| ErrTargetNotInNetwork errorCode = iota |
There was a problem hiding this comment.
preexisting, but errorCode should be exported if ErrTargetNotInNetwork is also exported for godocs
There was a problem hiding this comment.
could be made into a trivial follow up
|
two of the async benchmarks failed, perhaps an indicator that this introduces a performance regression? |
Manually checked the timing of a queryroutes call on testnet, didn't see a difference with master. Restarted itests |
|
Yes, does seem to be failing consistently. Will check it out. |
A unified policy differs between local channels and other channels on the network. There is more information available for local channels and this is used in the unified policy. Previously we used the pathfinding source pubkey to determine whether to apply the local channel logic or not. If queryroutes is executed with a source node that isn't the self node, this wouldn't work.
joostjager
force-pushed
the
extended-routing-failures
branch
from
32900ec to
9ae014e
Compare
|
Turned out to be a deadlock with getting the source node. Fixed now |
3 participants
Fixes #1680