build: pin golangci-lint version #3503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
approved these changes
Sep 13, 2019
joostjager
force-pushed
the
remove-whitespace-linter
branch
from
1128983 to
c206200
Compare
joostjager
changed the title
halseth
approved these changes
Sep 13, 2019
To prevent builds breaking when golangci-lint or any of the linters is updated.
joostjager
force-pushed
the
remove-whitespace-linter
branch
from
143bed6 to
a963b42
Compare
joostjager
force-pushed
the
remove-whitespace-linter
branch
from
a963b42 to
e0b0c72
Compare
joostjager
force-pushed
the
remove-whitespace-linter
branch
from
e0b0c72 to
2351758
Compare
cfromknecht
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/golangci/golangci-lint#install
A second commit disables
funlensettings. We have quite a few long functions. I tested and confirmed that changing those functions doesn't triggerfunlen. Only when a new function is created or an old long function is renamed, the linter error appears. But to not introduce too many potential issues now, we disable it completely. Later we may start experimenting with trying to force smaller functions.