backport: server: prevent duplicate onion addresses in getinfo

[bitromortac]

#10341

[gemini-code-assist]

Summary of Changes

Hello @bitromortac, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug that caused duplicate network addresses to appear in node announcements and the getinfo output. By introducing a de-duplication step in the server's node announcement generation process, it ensures that only unique addresses are broadcasted and reported, leading to more accurate and concise network information. This is a backport of a previously merged fix.

Highlights

• Duplicate Address Prevention: Implemented logic within the genNodeAnnouncement function to remove duplicate network addresses before signing the node announcement, ensuring cleaner getinfo output and node announcements.
• Release Notes Update: Updated the release-notes-0.20.1.md to document the fix for repeated network addresses in node announcements and getinfo output.
• Contributor Recognition: Added bitromortac to the list of contributors in the release notes for version 0.20.1.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports a fix to prevent duplicate addresses in getinfo and node announcements. The change in server.go correctly de-duplicates addresses in the genNodeAnnouncement function using a map to track unique addresses. This approach is clear, correct, and idiomatic Go. The release notes in docs/release-notes/release-notes-0.20.1.md have also been updated to reflect this fix and add a contributor. The changes are well-implemented and I have no further suggestions.

[saubyk]

Ack for backport into the 0.20 release branch