Skip to content

scripts: update hieblmi pgp key#10147

Merged
guggero merged 1 commit intolightningnetwork:masterfrom
hieblmi:update-hieblmi-key
Aug 11, 2025
Merged

scripts: update hieblmi pgp key#10147
guggero merged 1 commit intolightningnetwork:masterfrom
hieblmi:update-hieblmi-key

Conversation

@hieblmi
Copy link
Collaborator

@hieblmi hieblmi commented Aug 11, 2025

This PR updates the pgp key for hieblmi with a new expiration date.

[skip ci]

@hieblmi hieblmi requested review from guggero and ziggie1984 August 11, 2025 09:48
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the PGP key for user 'hieblmi' by replacing the existing key with a new one that includes an updated expiration date. This ensures the continued validity and security of signatures associated with this key.

Highlights

  • PGP Key Update: The PGP key for 'hieblmi' located at scripts/keys/hieblmi.asc has been updated. This update specifically replaces the old key with a new one, as indicated by the change in the key's content, which includes a new expiration date.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a PGP key. My review highlights a potentially missed step: updating the scripts/verify-install.sh script as per the repository's own documentation. This is a crucial step to prevent breaking the release verification process. I've added a comment with details.

Comment on lines +14 to +27
tCNTbHlnaHRuaW5nIDxoaWVibG1pQHByb3Rvbm1haWwuY29tPokCVwQTAQgAQQIb
AwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBDL36h56Azn303FkufgtRW6g
I8m/BQJmXLJVBQkLSK/jAAoJEPgtRW6gI8m/hy8P/jRi+yR9Lo78SPbklI/94iso
zvFAfaAXmU8yVD+kXwhL0ch6+vbZ74DolXGoVByY+OYb5tI4XDbc4/f9r35DABJn
jMCkOBPTfK1lY/kkSn2trc8joEQit43yRCZP9rKvrgXaJtWuYwOpAiaHTR0vylfO
Bhm36yQ4nv+Pv1fgyHcGmtxhYQjNRWgFw2p5/Hzzyc+iNjnCttY4PFBKIiaUUzIl
Vrtz2KWhq4Czvwnd4JXGXzrt+4klqxazGKypv8cnhodVOahx0tDmhnp+1YKerGcV
HljLTNwWBL7eI3oNe1pkZT4BC2meLdOdGDEvY5DgrcnmyLs14m8GOE2otnuNYyXy
jd2bXB1/YTNS+cfCwA6gKBpfXy3PsGkh0Un11NpuWLLsys1WVyOzSy/M11y3VM/E
tvJOXLK/YGMXY55XhqNTRIhsjgLFaKp9L44P2UHqy4hBshRN4hWrQCx5K39TkFTK
f8MR1ep8hiVcpVaArQSULVuTH3+huIJ8Hmc62gOEj5fLpVP98vr32vuoKBCr6SVw
t6YFP1cIfBHrQ19zw+n+56An2CqHjUVacjteQrkE0MKcOrngC0BGg8TLg6mtwnwG
jpJm7ZEYwuvVWULO7JeBXDL2QgaQmM5CGkfg5U1/173W7eChkkEBp9LguxsG6XXA
QG8aozxc5fuTQ6VxjAUmuQINBGR6A/IBEADSEs3XC7g44AykQ4s/INazgbtxXLxY

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The scripts/keys/README.md states that scripts/verify-install.sh must be updated when a key file is changed. This PR updates the PGP key but does not include changes to scripts/verify-install.sh. This omission is likely to break the release verification process, which may rely on the exact content of this key file (e.g., via a checksum). Please update scripts/verify-install.sh to accommodate the new key content.

Copy link
Collaborator Author

@hieblmi hieblmi Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist Since this PR only updates the content of the hieblmi.asc file there shouldn't be a change necessary to scripts/verify-install.sh. Could you confirm that and if true, remember this for future key updates?

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same key, new signature with extended validity date. LGTM 🎉

Copy link
Collaborator

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@guggero guggero merged commit d11d699 into lightningnetwork:master Aug 11, 2025
13 of 69 checks passed
@hieblmi hieblmi deleted the update-hieblmi-key branch August 11, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants