git: remove client submodule

[sputn1ck]

removes recursive submodule

[gemini-code-assist]

Summary of Changes

Hello @sputn1ck, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline the repository by eliminating the 'client' Git submodule. This action removes a recursive dependency, simplifying the project's configuration and reducing complexity in the codebase.

Highlights

• Submodule Removal: The 'client' Git submodule has been completely removed from the repository, simplifying the project's dependency structure.
• Configuration Update: The .gitmodules file was modified to remove the entry defining the 'client' submodule, including its path and URL.
• Submodule Reference Deletion: The actual reference to the 'client' submodule directory was deleted from the repository, ensuring a clean removal.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the client git submodule. The changes correctly delete the submodule's configuration from the .gitmodules file and remove the submodule directory pointer from the repository. The change is straightforward and appears to be a clean removal of the submodule dependency.

[claude]

PR Review: Remove Recursive Submodule

Summary

This PR correctly removes a recursive/circular submodule reference where the repository was referencing itself as a submodule. This is a clean and necessary fix.

Code Quality ✅

• Change is correct: The PR properly removes both the .gitmodules entry and the submodule directory reference
• Commit message follows conventions: Uses proper format "git: remove client submodule" with the package prefix
• Complete removal: Both files that define submodules are properly cleaned

Technical Analysis ✅

What was wrong:
The repository had a submodule configuration pointing to itself:

[submodule "client"]
    path = client
    url = https://github.com/lightninglabs/darepo-client.git

This creates a recursive/circular reference which can cause:

• Clone issues (infinite recursion with --recursive)
• Confusion for developers
• Potential CI/CD problems
• Wasted disk space and bandwidth

What the fix does:

1. Removes the .gitmodules entry completely (file now empty)
2. Removes the submodule reference from git's tracking

Verification ✅

• No other references to this submodule exist in:
  • Documentation (README.md, PLANS.md, etc.)
  • Build files (Makefile)
  • CI/CD configurations
  • Source code

Recommendations

1. Consider deleting .gitmodules entirely: Since the file is now empty, you may want to remove it completely in a follow-up commit or amend this one
2. Verify clean clones: After merge, test that fresh clones work correctly without any submodule warnings
3. Check CI pipelines: Ensure any CI jobs that may have used --recurse-submodules still function properly

Potential Follow-up

# If desired, fully remove the empty .gitmodules file:
git rm .gitmodules

Verdict: APPROVED ✅

This is a good fix for a problematic configuration. The change is minimal, correct, and addresses the issue described in the PR body.