Skip to content

txconfirm: Preserve progress after failed fee bump - #1126

Open
fzlzjerry wants to merge 1 commit into
lightninglabs:mainfrom
fzlzjerry:fix-txconfirm-bump-count
Open

txconfirm: Preserve progress after failed fee bump#1126
fzlzjerry wants to merge 1 commit into
lightninglabs:mainfrom
fzlzjerry:fix-txconfirm-bump-count

Conversation

@fzlzjerry

Copy link
Copy Markdown

Summary

  • add a dedicated fee-bump failure event to the tracked transaction FSM
  • preserve the last successful fee rate, child transaction, and bump count after interval or forced bump failures
  • update only retry pacing and cover the FSM plus both actor paths with regression tests

Fixes #665

Testing

  • make unit pkg=./txconfirm timeout=5m
  • make unit-race pkg=./txconfirm timeout=5m
  • make unit pkg=./txconfirm case=TestFailedFeeBumpPreservesProgress log="stdlog trace" timeout=5m
  • make lint-changed-local workers=2
  • make fmt-changed-check
  • make tidy-module-check
  • make build
  • make commitmsg-lint commit=HEAD

Use a dedicated fee-bump failure event to preserve the last
successful broadcast metadata and bump count while advancing retry
pacing.

Cover interval-driven, forced, and FSM failure paths with
regression tests.
@fzlzjerry
fzlzjerry marked this pull request as ready for review August 11, 2026 08:57
Copilot AI lite review requested due to automatic review settings August 11, 2026 08:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

txconfirm: BumpCount increments on a failed fee-bump

2 participants