-
Notifications
You must be signed in to change notification settings - Fork 9
actor: durable mailbox backpressure watermarks + depth metrics #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roasbeef
wants to merge
12
commits into
main
Choose a base branch
from
durable-mailbox-watermarks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a7e3ae1
actor: add durable mailbox backpressure watermarks
Roasbeef e0711c7
db: add mailbox depth count queries
Roasbeef dbde8f3
db: regenerate sqlc stubs for mailbox depth queries
Roasbeef b4c0a3f
db: implement actor.MailboxDepthStore on the delivery store
Roasbeef c7b7bc0
metrics+waved: export durable mailbox depth scrape gauges
Roasbeef 5d0e7c0
serverconn: classify mailbox saturation as dispatch deferral
Roasbeef 58a4aa8
multi: enable backlog watermarks on the durable actor fleet
Roasbeef 765d424
docs: document the backpressure watermark contract
Roasbeef 82e5bb2
actor: exempt outbox hand-offs from watermarks, harden depth probe
Roasbeef 95e773a
multi: mark boot restore and resume messages as control priority
Roasbeef 14c26c6
docs: correct the watermark exemption contract
Roasbeef 8c98bce
ledger+actor: soft-only ledger watermark, keep probe delta on reset
Roasbeef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an outbox targets any actor that opted into the hard watermark,
OutboxPublisher.deliverMessagestill callsref.Tell, so the folded path reaches this check and returnsErrMailboxSaturated. Each retry incrementsDeliveryAttempts, and after the default 10 attempts the publisher dead-letters the event; a temporary backlog can therefore permanently lose a durable outbox message instead of using the deliberately unthrottled folded enqueue. Exempt folded sends (for example via their outbox context) from this admission check.AGENTS.md reference: baselib/actor/AGENTS.md:L73-L74
Useful? React with 👍 / 👎.