Show all vtxos except forfeited and spent, add option to show all - #1118
Open
Liongrass wants to merge 2 commits into
Open
Show all vtxos except forfeited and spent, add option to show all#1118Liongrass wants to merge 2 commits into
Liongrass wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses #1116
As of now,
wavecli ark vtxos listonly shows live VTXOs. This means that any application building on that RPC call has to make repeated RPC calls to fetch all VTXOs, regarding of their status. By default, any VTXO that isn'tliveappears to be simply missing.Available statuses include:
live,pending_forfeit,forfeiting,forfeited,spent,unilateral_exit,failed,spendingIn the first commit, we expand this to all VTXOs, except forfeited and spent VTXOs. I believe this best represents the VTXOs a user would care about.
In the second commit, we add a new
--show-allflag that gives the user or application the option to query all VTXOs, regardless of their status, and then filter themselves.Future work to consider:
--statusflags to be passed