tools: Add semantic actor framework analyzer - #1063
Draft
sputn1ck wants to merge 2 commits into
Draft
Conversation
Use typed AST and SSA facts to enforce durable TLV schemas, protofsm table invariants, detached Ask lifetimes, and actor transaction boundaries. Model held writers separately from stripped contexts so the analyzer catches both historical mailbox deadlocks.
Enable the typed framework plugin in the existing golangci-lint job so every client change is checked for actor, transaction, TLV, and protofsm invariants.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
frameworkgolangci-lint plugin alongside the existingllpluginCallerCtxand keep the concurrent-classic escape test-onlyThe transaction analysis deliberately models “writer held” separately from “context carries a transaction.” That distinction catches both historical mailbox failure modes: waiting on an Ask whose durable enqueue is still uncommitted, and stripping the transaction before an enqueue that then tries to acquire a second writer.
Diagnostics
ATL001-ATL003: durable TLV encoding and codec registrationPFS001-PFS005: protofsm transition-table invariantsALC001-ALC003: detached Ask and durable actor lifecycleATX001-ATX005: actor transaction/deadlock boundariesValidation
GOWORK=off go test ./...intools/lintersGOWORK=off go vet ./...intools/lintersGOGC=50 make lint-local workers=4: 0 issuesGOWORK=off go test ./...make tidy-module-checkmake fmt-changed-checkmake commitmsg-lint range='origin/main..HEAD'