RFQ cleanup #860
Merged
RFQ cleanup #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
reviewed
Mar 28, 2024
In this commit we replace methods `encodeRecords` and `decodeRecords` with a single method called `records`.
Function `wait.NoError` will call the given target function multiple times. Whereas `BeforeTimeout` calls the given target function once. We don't want to call the target function more than once in this itest. This commit changes `wait.NoError` calls to `BeforeTimeout`.
dstadulis
added
RFQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was recently reviewed, approved, and merged: #835
I noticed that some of the review comments could also apply to other parts of the RFQ code that were not changed in the above PR.
This PR improves the RFQ code following the review comments from #835.