go.mod: bump [email protected]; bump [email protected] #1861
Conversation
Run commands: ``` go get github.com/lightningnetwork/[email protected] go get github.com/lightninglabs/[email protected] go get github.com/lightningnetwork/[email protected] go mod tidy ``` Fix a compatibility issue by changing lightning-onion to a common version. Revise `chainntnfs.ConfirmationEvent` field for compatibility.
Summary of ChangesHello @ffranr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating core dependencies to prepare for the next stable release. It primarily bumps the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the LND dependencies to a non-RC version, which aligns with the stated goal. The accompanying code change in lndservices/daemon_adapters.go addresses a compatibility issue introduced by the dependency bump. However, I've identified a high-severity issue in lndservices/daemon_adapters.go where several notification channels are created but never populated, potentially leading to deadlocks for consumers of this function. Additionally, error conditions like transaction re-orgs are not handled because a crucial error channel is ignored. I've provided a review comment with a suggestion to mitigate the immediate deadlock risk.
Pull Request Test Coverage Report for Build 18978409430Details
💛 - Coveralls |
There was a problem hiding this comment.
Nice one. 👍 👍
This looks good to me. The LiT tests in CI appear to be complaining solely due to the lightning-onion downgrade.
Gemini is also complaining about something in daemon_adapters.go, but it doesn't look to be related to your change, and without more context from Gemini I have to assume it's a false positive.
|
Before merge, I'll take a look at the lit CI fail. |
Goal: bump LND to a non RC version so the next non RC tap release can ship in the next non RC litd release.
Run commands:
Fix a compatibility issue by changing lightning-onion to a common version. Revise
chainntnfs.ConfirmationEventfield for compatibility.