Conversation
Pull Request Test Coverage Report for Build 13795013078Details
💛 - Coveralls |
GeorgeTsagk
force-pushed
the
rfq-negotiation-groupkey
branch
from
a76775a to
269ad4b
Compare
GeorgeTsagk
force-pushed
the
itest-oracle-harness
branch
from
19876aa to
52c7c50
Compare
guggero
approved these changes
Feb 25, 2025
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Linter is unhappy, otherwise LGTM 🎉
ffranr
reviewed
Feb 25, 2025
Contributor
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
Could we specify different oracle servers for alice, bob, and carol from the get go perhaps?
Comment on lines
32
to
42
| bidPrices map[string]rfqmath.BigIntFixedPoint | ||
| askPrices map[string]rfqmath.BigIntFixedPoint |
Contributor
There was a problem hiding this comment.
i think you should add a comment to explain what string is here. in other words, I think we should have field level doc comments here (even though it's test code).
GeorgeTsagk
force-pushed
the
itest-oracle-harness
branch
from
52c7c50 to
3351424
Compare
Member
Author
|
Thanks for the feedback @ffranr , addressed your comments |
ffranr
approved these changes
Feb 27, 2025
GeorgeTsagk
force-pushed
the
rfq-negotiation-groupkey
branch
from
269ad4b to
7c660bd
Compare
GeorgeTsagk
force-pushed
the
itest-oracle-harness
branch
from
3351424 to
80294e4
Compare
Contributor
We should be careful when comparing fields that have a |
GeorgeTsagk
force-pushed
the
rfq-negotiation-groupkey
branch
from
7c660bd to
6cf7190
Compare
The public oracle server RPC endpoints for querying prices would only accept a specifier that sets only the asset ID. We may now accept group keys as well, so we consider any specifier to be valid. This is needed as we're later going to create a oracle rpc server harness to test out this code path.
In order for the oracle server harness to have a native way of providing us with logs in the itests we need to set up an itest logger, which is also initiated during test harness setup.
Adds a simple oracle server harness, this is a copy of the oracle harness implementation in LitD. We need this to have greatest code coverage in our tapd itests and also to have moving prices during the itest execution, allowing the creation of more complex scenarios.
Not all itests need to use an oracle server harness, so we introduce a functional option that may be defined when setting up a harness. This will reduce the overall diff as previous callers of the harness setup functions won't need to change their arguments.
In order to test the new harness and the previous changes, we introduce the oracle server harness in one of our rfq related tests. The 2 peers in this test will now query a real oracle price server instead of defaulting to their mock.
GeorgeTsagk
force-pushed
the
itest-oracle-harness
branch
from
80294e4 to
4048004
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the oracle harness that is used in the LitD itests to our tapd repo. This will allow us to run an actual dummy grpc oracle server that the tapd instances of our itests can use. This will offer a slightly bigger code coverage in itests plus enable more complex scenarios with moving prices.
This branch is based on
rfq-negotiation-groupkey, which is also set as the base of this GH pull request in order to not see duplicate commits.SubscribeRfqEventNtfnsRPC endpoint will crash if it tries to marshal the rfq message sent by our peer if they consider our price unacceptable.