Update commit_hash field to GetInfo response #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
reviewed
May 22, 2025
Member
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
Looks good, just one comment!
Makefile
Outdated
| LDFLAGS := -ldflags "-X $(PKG).Commit=$(COMMIT)" | ||
| COMMIT := $(shell git describe --abbrev=40 --dirty --tags) | ||
| COMMIT_HASH := $(shell git rev-parse HEAD) | ||
| DIRTY := $(shell git diff-index --quiet HEAD -- || echo -dirty) |
Member
There was a problem hiding this comment.
Instead of -dirty we should store it as dirty.
Contributor
Author
There was a problem hiding this comment.
Ah good idea! Addressed with the latest push :).
Update the output of the `commit_hash` field in the GetInfoResponse. The `commit_hash` field will contain the most recent commit_hash that the build was based on. If the build had uncommitted changes, this field will contain the most recent commit hash, suffixed by "-dirty". Note that this change also changes the output of `commit` field in the `--version` command. The `Commit` field will now contain most recent git commit tag.
The `commit_hash` field will contain the full commit hash of the commit that build was based on.
ViktorT-11
force-pushed
the
2025-05-update-getinfo-response
branch
from
0198172 to
3aaef99
Compare
Contributor
Author
|
Thanks for the swift review @bhandras 🙏! Addressed your feedback with the latest push. |
hieblmi
approved these changes
May 22, 2025
Collaborator
hieblmi
left a comment
hieblmi
left a comment
There was a problem hiding this comment.
tACK, thanks @ViktorTigerstrom!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
GetInforesponse to adhere to lightninglabs/lightning-terminal#1034.In general it updates the output of the
commit_hashfield in the GetInfoResponse.The
commit_hashfield will now contain the most recent commit_hash that the build was based on. If the build had uncommitted changes, this field will contain the most recent commit hash, suffixed by "-dirty".We also change the output of
commitfield in the--versioncommand. TheCommitfield will now contain most recent git commit tag.Note that both of these changes are breaking changes!
Additionally we also add a
commit_hashpart of the output of the--versionoutput.