store-secret: read up to EOF from stdin #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we don't write a newline by ourselves, we also need to allow the EOF signal to terminate a string we're reading from stdin.
bhandras
approved these changes
Mar 22, 2022
thinkmassive
approved these changes
Mar 22, 2022
Contributor
thinkmassive
left a comment
thinkmassive
left a comment
There was a problem hiding this comment.
Looks good! Maybe we can use kind for testing k8s interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have tested everything on an actual cluster before merging #4 🙈
Unfortunately the interaction with k8s is a bit tricky to test in unit tests, so we don't have all functionality covered yet. But I'll look into ways of simulating a k8s backend so we can add more unit tests.
I now manually built and deployed this version on a cluster and made sure everything works!