lndinit: add ability to write to k8s configmap #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinrzachman
force-pushed
the
store-configmap
branch
3 times, most recently
from
a9c7110 to
60df4b7
Compare
calvinrzachman
commented
Jan 16, 2024
k8s.go
Outdated
| ObjectTypeConfigMap k8sObjectType = "ConfigMap" | ||
| ) | ||
|
|
||
| type k8sObjectOptions struct { |
Contributor
Author
There was a problem hiding this comment.
If the rename of the CLI flag to the more general --k8s.name is not preferred, we could just make a separate k8sConfigmapOptions struct.
calvinrzachman
force-pushed
the
store-configmap
branch
from
60df4b7 to
10064d3
Compare
djkazic
approved these changes
Jan 16, 2024
guggero
reviewed
Jan 17, 2024
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Very useful new function.
Main comment is about not breaking existing users by renaming flags. So we'd rather have some duplicated code.
I'll do a full review with manual tests once the diff is updated.
calvinrzachman
force-pushed
the
store-configmap
branch
5 times, most recently
from
ba436e9 to
d23278b
Compare
We'll use this to write connection relateed information for consumption by payment service proxy.
calvinrzachman
force-pushed
the
store-configmap
branch
from
d23278b to
0238e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR equips lndinit with the ability to write arbitrary key/value data to a Kubernetes Configmap object.
base64encoded.