Skip to content

Conversation

@calvinrzachman
Copy link
Contributor

No description provided.

github.com/lightninglabs/protobuf-hex-display v1.4.3-hex-display
github.com/lightningnetwork/lnd v0.16.3-beta
github.com/stretchr/testify v1.8.1
google.golang.org/grpc v1.41.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to restrict the other updates here? How'd you bump the version locally?

Mentioning as there's some gRPC/LNC related stuff. we've fixed in some later versions re L402 compat, wanting to make sure we don't indirectly break things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I do:

  • edit this manually to be github.com/lightningnetwork/lnd v0.16.4-beta.rc1
  • run go mod tidy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks much better in the latest diff.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐍

@Roasbeef Roasbeef merged commit 906f788 into lightninglabs:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants