Skip to content

Conversation

Roasbeef
Copy link
Member

No description provided.

@dstadulis dstadulis added this to the tapd v0.5 milestone Dec 15, 2024
@Roasbeef Roasbeef changed the title tapd: add new CLI command for decodeassetinvoice along with corresponding itest for `DecodeAssetPayReq tapd: add new CLI command for decodeassetinvoice along with corresponding itest for DecodeAssetPayReq Dec 15, 2024
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@GeorgeTsagk
Copy link
Member

needs a go.mod replace to point to lightninglabs/taproot-assets#1253

@guggero guggero force-pushed the update-to-lnd-18-4 branch 2 times, most recently from d59c717 to 76e65f1 Compare December 16, 2024 14:54
@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch 3 times, most recently from 51d4166 to cd8890b Compare December 17, 2024 14:08
@guggero guggero force-pushed the update-to-lnd-18-4 branch 2 times, most recently from b674ce2 to 411f881 Compare December 17, 2024 20:32
@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch 2 times, most recently from ab21715 to 3b68a35 Compare December 18, 2024 16:41
go.mod Outdated
github.com/lightninglabs/pool/auctioneerrpc v1.1.2
github.com/lightninglabs/pool/poolrpc v1.0.0
github.com/lightninglabs/taproot-assets v0.5.0-rc2.0.20241217185126-a9a2744061f1
github.com/lightninglabs/taproot-assets v0.5.0-rc2.0.20241218162444-57c2454c050e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dep branch must be rebased in order to build

@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch from 3b68a35 to 4281f22 Compare December 18, 2024 17:46
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM pending linter fixes.

@Roasbeef Roasbeef force-pushed the decode-asset-pay-req-itest branch from 4281f22 to 002479e Compare December 19, 2024 11:52
@guggero guggero merged commit 95faab7 into update-to-lnd-18-4 Dec 19, 2024
8 of 13 checks passed
@guggero guggero deleted the decode-asset-pay-req-itest branch December 19, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants