custom channels: add coop close balance assertions for grouped asset channels#1056
Merged
custom channels: add coop close balance assertions for grouped asset channels#1056
Conversation
ffranr
approved these changes
May 7, 2025
Contributor
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
Needs rebase. I think we might be able to drop the first three commits.
itest/assets_test.go
Outdated
Comment on lines
+1985
to
+1986
| t.Logf("Is script key %s (asset ID %s) in list of asset IDs "+ | ||
| "(%v)?", scriptKeyStr, assetIDStr, localAssetIDs) |
Contributor
There was a problem hiding this comment.
maybe we don't need this log message?
Contributor
Author
There was a problem hiding this comment.
Ah yes, was left over from debugging. Removed.
guggero
force-pushed
the
group-key-support-balance-fixes
branch
2 times, most recently
from
13357d4 to
a1a6473
Compare
Makes sure we properly assert the final closing balances of coop closed grouped asset channels.
guggero
force-pushed
the
group-key-support-balance-fixes
branch
from
a1a6473 to
ab3eb92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on lightninglabs/taproot-assets#1505.
Depends on #1054.