lit: make sure to always close stores on errored start-up

[ellemouton]

Ensure that if any store init in the stores struct creation fails, then any successful stores are still closed during shutdown.

This addresses this review comment

[bitromortac]

stoppint -> stopping

Could we combine this with the firewall's close function?

	stores.closeFns["firewall"] = func() error {
		err := stores.firewall.Stop()
		if err != nil {
			return fmt.Errorf("error stopping firewall DB: %v", err)
		}

		return firewallDB.Close()
	}

[bitromortac]

or do we actually need closeFns, since we have access to all stores and can call their Close/Stop methods when shutting down?

[ellemouton]

Could we combine this with the firewall's close function?

The reason i did not do that is cause we Start it outside. So feels like the same layer should be responsible for calling Stop.

[ellemouton]

stoppint -> stopping

Will fix on next push after more review

[ellemouton]

or do we actually need closeFns, since we have access to all stores and can call their Close/Stop methods when shutting down?

we could - but then need to do nil check for each. just thought that this was cleaner

[ellemouton]

also, remember that this is all temporary - we're just doing it like this while we have these 2 versions. We will later force the migration and only have one. At that point, we dont need the stores struct and can handle each store individually in the terminal struct again

[bitromortac]

Thanks for the explanation, looks good!

[ViktorT-11]

Looks great, thanks for fixing this 🙏!