multi: go version and linter bump#1006
Merged
ellemouton merged 4 commits intolightninglabs:masterfrom Mar 24, 2025
Merged
Conversation
We update the go version in our go.mod, for our linter, GH workflows and makefile.
Bump the go version in our various docker files.
Bump the tools packge golang version along with the linter version. Adjust the linter config file accordingly.
Since we have multiple itest artefacts with the same name now, we need to ensure they have different names or else the upload will fail.
ellemouton
added
the
no-changelog
bitromortac
approved these changes
Mar 17, 2025
| - G402 # Look for bad TLS connection settings. | ||
| - G306 # Poor file permissions used when writing to a new file. | ||
| - G601 # Implicit memory aliasing in for loop. | ||
| - G115 # Integer overflow in conversion. |
Contributor
There was a problem hiding this comment.
maybe we could fix those in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR siphons of a few commits from #998 which we can get in without the LND dep bump.
The main purpose being so that other PRs that introduce more generic concepts can pass the linter check (the updated linter dep works better with generics).