Skip to content

Drop a pile of Arcs and OutputSweeper::new_with_kv_store_sync #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 6 commits into from
Sep 25, 2025

Drop unnecessary `Arc`s in `lightning-liquidity`'s `EventQueue`

5e679b4
Select commit
Loading
Failed to load commit list.
Merged

Drop a pile of Arcs and OutputSweeper::new_with_kv_store_sync #4119

Drop unnecessary `Arc`s in `lightning-liquidity`'s `EventQueue`
5e679b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 25, 2025 in 1s

88.55% (+0.02%) compared to 4c9c211

View this Pull Request on Codecov

88.55% (+0.02%) compared to 4c9c211

Details

Codecov Report

❌ Patch coverage is 72.86822% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (4c9c211) to head (5e679b4).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
lightning-background-processor/src/lib.rs 66.30% 31 Missing ⚠️
lightning-liquidity/src/utils/time.rs 0.00% 3 Missing ⚠️
lightning-liquidity/src/manager.rs 94.73% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4119      +/-   ##
==========================================
+ Coverage   88.52%   88.55%   +0.02%     
==========================================
  Files         179      179              
  Lines      134270   134310      +40     
  Branches   134270   134310      +40     
==========================================
+ Hits       118865   118939      +74     
+ Misses      12655    12612      -43     
- Partials     2750     2759       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov