Properly consider blinded paths in InFlightHtlcs #4072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next commit we'll track blinded path in-flights in `InFlightHtlcs` as well as unblinded hops, so here we convert `InFlightHtlcs` to a named-field struct so that we can add more fields to it with less confusion.
Its not clear why this needs to be serialized at all (it should generally always be generated live when needed), but its serialization isn't forward-compatible, so really needs to be dropped so that we can add additional field(s) to `InFlightHtlcs`.
|
I've assigned @tankyleo as a reviewer! |
When paying a BOLT 12 invoice an amount greater than any one of multiple blinded paths, we need to track how much is in-flight across the paths when retrying. Here we do so, tracking blinded path usage in a new field in `InFlightHtlcs`. Fixes lightningdevkit#2737
TheBlueMatt
force-pushed
the
2025-09-bp-usage-tracking
branch
from
3f57558 to
4cbd556
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4072 +/- ##
==========================================
+ Coverage 88.33% 88.36% +0.02%
==========================================
Files 177 177
Lines 131896 132011 +115
Branches 131896 132011 +115
==========================================
+ Hits 116512 116645 +133
+ Misses 12728 12704 -24
- Partials 2656 2662 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paying a BOLT 12 invoice an amount greater than any one of
multiple blinded paths, we need to track how much is in-flight
across the paths when retrying. Here we do so, tracking blinded
path usage in a new field in
InFlightHtlcs.Fixes #2737