Implement core::fmt::Display for HumanReadableName #3829
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Basically LGTM, one comment.
| } | ||
| } | ||
|
|
||
| impl std::fmt::Display for HumanReadableName { |
There was a problem hiding this comment.
As we want to keep this crate no_std-compatible, please use core::fmt instead of std::fmt. Any uses of std would need to be feature-gated behind the std feature, but in this case there is no reason to.
There was a problem hiding this comment.
Okay will do, thanks!
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
chuksys
changed the title
chuksys
force-pushed
the
implement-display-for-hrn
branch
from
209f0f2 to
004937b
Compare
|
Feel free to squash the fixups, which should fix CI. |
chuksys
force-pushed
the
implement-display-for-hrn
branch
from
004937b to
3484eb0
Compare
|
I think I need to add a test case that asserts the correct HRN display format, for mutation testing to pass in CI. |
chuksys
force-pushed
the
implement-display-for-hrn
branch
from
3484eb0 to
81b201a
Compare
4 participants
Closes #3823
This PR implements
DisplayforHumanReadableNamewhich allows us to print a HRN as₿user@domain.