Skip to content

Enable Creation of Offers and Refunds Without Blinded Path #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 11 commits into from
Jul 24, 2025
Merged

Enable Creation of Offers and Refunds Without Blinded Path #3246

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e8f5f90
Fixup: Remove stale documentation
shaavan Jul 1, 2025
5bc12d4
Fix: Ignore SCIDs when creating full-length blinded paths
shaavan Jun 19, 2025
d6099c3
Update `create_blinded_paths` to accept `Vec<MessageForwardNode>`
shaavan Mar 27, 2025
d78d640
Introduce `NodeIdMessageRouter` and `NullMessageRouter`
shaavan Mar 27, 2025
26e4fe6
Refactor: Update TestMessageRouter to enum
shaavan Jun 18, 2025
1a57e63
Update `DefaultMessageRouter` to always create compact blinded paths
shaavan Jun 13, 2025
ddb1167
Update `create_offer_builder` to use `create_blinded_paths`
shaavan Jun 20, 2025
d6292d1
Update `create_refund_builder` to use `create_blinded_paths`
shaavan Jun 21, 2025
512e825
Update handle_offer_paths_request to use `create_blinded_paths`
shaavan Jul 24, 2025
80e7385
Cleanup: Remove redundant create_blinded_paths variants
shaavan Jul 24, 2025
596cf47
Test: Add coverage for Offers and Refunds without blinded paths
shaavan Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11467,8 +11467,7 @@ macro_rules! create_offer_builder { ($self: ident, $builder: ty) => {
///
/// Uses [`MessageRouter`] to construct a [`BlindedMessagePath`] for the offer based on the given
/// `absolute_expiry` according to [`MAX_SHORT_LIVED_RELATIVE_EXPIRY`]. See those docs for

@TheBlueMatt TheBlueMatt Jul 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we never use MAX_SHORT_LIVED_RELATIVE_EXPIRY at all in the entire crate anymore (except for tests), we should remove references to that and drop the constant too.

/// privacy implications as well as those of the parameterized [`Router`], which implements
/// [`MessageRouter`].
/// privacy implications.

@TheBlueMatt TheBlueMatt Jul 24, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any "privacy implications" in those places, so not sure what this is referring to tbh.

///
/// Also, uses a derived signing pubkey in the offer for recipient privacy.
///
Expand Down Expand Up @@ -11519,8 +11518,7 @@ macro_rules! create_refund_builder { ($self: ident, $builder: ty) => {
///
/// Uses [`MessageRouter`] to construct a [`BlindedMessagePath`] for the refund based on the given
/// `absolute_expiry` according to [`MAX_SHORT_LIVED_RELATIVE_EXPIRY`]. See those docs for
/// privacy implications as well as those of the parameterized [`Router`], which implements
/// [`MessageRouter`].
/// privacy implications.
///
/// Also, uses a derived payer id in the refund for payer privacy.
///
Expand Down Expand Up @@ -11716,8 +11714,7 @@ where
/// # Privacy
///
/// For payer privacy, uses a derived payer id and uses [`MessageRouter::create_blinded_paths`]
/// to construct a [`BlindedMessagePath`] for the reply path. For further privacy implications, see the
/// docs of the parameterized [`Router`], which implements [`MessageRouter`].
/// to construct a [`BlindedMessagePath`] for the reply path.
///
/// # Limitations
///
Expand Down Expand Up @@ -11896,8 +11893,7 @@ where
/// # Privacy
///
/// For payer privacy, uses a derived payer id and uses [`MessageRouter::create_blinded_paths`]
/// to construct a [`BlindedMessagePath`] for the reply path. For further privacy implications, see the
/// docs of the parameterized [`Router`], which implements [`MessageRouter`].
/// to construct a [`BlindedMessagePath`] for the reply path.
///
/// # Limitations
///
Expand Down
3 changes: 1 addition & 2 deletions lightning/src/offers/flow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,7 @@ where
///
/// Uses [`MessageRouter`] to construct a [`BlindedMessagePath`] for the offer based on the given
/// `absolute_expiry` according to [`MAX_SHORT_LIVED_RELATIVE_EXPIRY`]. See those docs for
/// privacy implications, as well as those of the parameterized [`Router`], which implements
/// [`MessageRouter`].
/// privacy implications.
///
/// Also uses a derived signing pubkey in the offer for recipient privacy.
///
Expand Down