Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling for channels which fail to be created in funding_transaction_generated_intern #3029

Merged
merged 2 commits into from
May 3, 2024
Merged

Add error handling for channels which fail to be created in funding_transaction_generated_intern #3029

merged 2 commits into from
May 3, 2024

Commits on Apr 30, 2024

  1. Close channels when find_funding_output fails to find an output 

    In `funding_transaction_generated_intern`, if `find_funding_output`
fails (e.g. due to the require output not being present in the
provided funding transaction) we'd previously not generated a
`ChannelClosed` event which leaves users possibly in a confused
state.

Here we fix this, also fixing the relevant tests to check for the
new event.

Fixes lightningdevkit#2843.
    @TheBlueMatt
    TheBlueMatt committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6960210 View commit details
    Browse the repository at this point in the history

  2. Send peers error messages for failures due to invalid batch funding 

    If we fail to fund a batch open we'll force-close all channels in
the batch, however would previously fail to send error messages to
our peers for any channels we were due to test after the one that
failed.

This commit fixes that issue, sending the required error messages
to allow our peers to clean up their state.
    @TheBlueMatt
    TheBlueMatt committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b811cba View commit details
    Browse the repository at this point in the history