Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BlindedHopFeatures optional per spec #2945

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Make BlindedHopFeatures optional per spec #2945

merged 1 commit into from
Mar 19, 2024

Conversation

valentinewallace
Copy link
Contributor

The spec states that if these features are missing, we MUST process the message as if it were present and contained an empty array. See [1].

H/t to @carlaKC for catching this!

@valentinewallace
Make blinded hop features optional per spec.
18ebbf7 
The spec states that if these features are missing, we MUST process the message
as if it were present and contained an empty array.
@valentinewallace valentinewallace added this to the 0.0.122 milestone Mar 18, 2024
TheBlueMatt
TheBlueMatt approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, easy enough. Strictly more accepting and not changing the existing behavior. Should we also change our serialization-side to take advantage of the size reduction by not writing out features if they're empty?

@TheBlueMatt TheBlueMatt merged commit b747b39 into lightningdevkit:main Mar 19, 2024
16 checks passed
@valentinewallace valentinewallace mentioned this pull request Mar 19, 2024
Merged
@valentinewallace
Copy link
Contributor Author

Sure, easy enough. Strictly more accepting and not changing the existing behavior. Should we also change our serialization-side to take advantage of the size reduction by not writing out features if they're empty?

Sure, opened #2949!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.123
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valentinewallace @TheBlueMatt