Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeId::from_slice #2942

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

benthecarman
Copy link
Contributor

nice utility function

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.18%. Comparing base (36e434d) to head (227d73d).
Report is 64 commits behind head on main.

Files Patch % Lines
lightning/src/routing/gossip.rs 0.00% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2942      +/-   ##
==========================================
+ Coverage   89.13%   89.18%   +0.05%     
==========================================
  Files         117      117              
  Lines       94657    95530     +873     
  Branches    94657    95530     +873     
==========================================
+ Hits        84369    85202     +833     
- Misses       7811     7844      +33     
- Partials     2477     2484       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Simple enough, so I'll just go ahead and merge this.

@tnull tnull merged commit 282b52f into lightningdevkit:main Mar 18, 2024
15 of 16 checks passed
@benthecarman benthecarman deleted the node-id-slice branch March 18, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants