Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electrum support to lightning-transaction-sync #2685

Merged
merged 10 commits into from
Nov 27, 2023
Merged

Add electrum support to lightning-transaction-sync #2685

merged 10 commits into from
Nov 27, 2023

Commits on Nov 23, 2023

  1. Return confirmation height via Confirm::get_relevant_txids 

    We previously included the block hash, but it's also useful to include
the height under which we expect the respective transaction to be
confirmed.
    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c8ff321 View commit details
    Browse the repository at this point in the history

  2. Use upstream TestLogger util in tx sync tests

    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5b7c1d5 View commit details
    Browse the repository at this point in the history

  3. Improve EsploraSyncClient logging 

    We give some more information while reducing the log levels to make the
logging less spammy.

We also convert one safe-to-unwrap case from returning an error to
unwrapping the value.
    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    48c46bf View commit details
    Browse the repository at this point in the history

  4. Improve EsploraSyncClient test coverage 

    In particular, we now test `register_output` functionality, too.
    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e14e2c3 View commit details
    Browse the repository at this point in the history

  5. Move sync_ methods to SyncState

    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    82f4c10 View commit details
    Browse the repository at this point in the history

  6. Set pending_sync when last-minute check fails in Esplora

    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d2ecf07 View commit details
    Browse the repository at this point in the history

  7. Implement ElectrumSyncClient

    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4dd5ccb View commit details
    Browse the repository at this point in the history

  8. Add Electrum integration test

    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    28c14cd View commit details
    Browse the repository at this point in the history

  9. DRY up Esplora/Electrum integration_tests

    @tnull
    tnull committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c2e81fb View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Use esplora-client's async-https-rustls feature 

    Now that we upgraded `esplora-client` to 0.6 we can use
`async-https-rustls` instead of manually overriding the `reqwest`
dependency.
    @tnull
    tnull committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    31ea90e View commit details
    Browse the repository at this point in the history