-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add electrum support to lightning-transaction-sync
#2685
Merged
TheBlueMatt
merged 10 commits into
lightningdevkit:main
from
tnull:2022-12-add-electrum-sync
Nov 27, 2023
Merged
Add electrum support to lightning-transaction-sync
#2685
TheBlueMatt
merged 10 commits into
lightningdevkit:main
from
tnull:2022-12-add-electrum-sync
Nov 27, 2023
Commits on Nov 23, 2023
-
Return confirmation height via
Confirm::get_relevant_txids
We previously included the block hash, but it's also useful to include the height under which we expect the respective transaction to be confirmed.
Configuration menu - View commit details
-
Copy full SHA for c8ff321 - Browse repository at this point
Copy the full SHA c8ff321View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b7c1d5 - Browse repository at this point
Copy the full SHA 5b7c1d5View commit details -
Improve
EsploraSyncClient
loggingWe give some more information while reducing the log levels to make the logging less spammy. We also convert one safe-to-unwrap case from returning an error to unwrapping the value.
Configuration menu - View commit details
-
Copy full SHA for 48c46bf - Browse repository at this point
Copy the full SHA 48c46bfView commit details -
Improve
EsploraSyncClient
test coverageIn particular, we now test `register_output` functionality, too.
Configuration menu - View commit details
-
Copy full SHA for e14e2c3 - Browse repository at this point
Copy the full SHA e14e2c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82f4c10 - Browse repository at this point
Copy the full SHA 82f4c10View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2ecf07 - Browse repository at this point
Copy the full SHA d2ecf07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dd5ccb - Browse repository at this point
Copy the full SHA 4dd5ccbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28c14cd - Browse repository at this point
Copy the full SHA 28c14cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e81fb - Browse repository at this point
Copy the full SHA c2e81fbView commit details
Commits on Nov 24, 2023
-
Use
esplora-client
'sasync-https-rustls
featureNow that we upgraded `esplora-client` to 0.6 we can use `async-https-rustls` instead of manually overriding the `reqwest` dependency.
Configuration menu - View commit details
-
Copy full SHA for 31ea90e - Browse repository at this point
Copy the full SHA 31ea90eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.