Makes Features::from_be_bytes public #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr-gi
force-pushed
the
20231003-expose-from-be-bytes
branch
from
7b72c6b
to
60607b9
Compare
valentinewallace
previously approved these changes
Oct 3, 2023
tnull
reviewed
Oct 5, 2023
lightning/src/ln/features.rs
Outdated
| @@ -718,7 +718,11 @@ impl<T: sealed::Context> Features<T> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn from_be_bytes(mut flags: Vec<u8>) -> Features<T> { | |||
| /// Create a Features given a set of flags, in big-endian. This is in byte order from | |||
There was a problem hiding this comment.
nit:
Suggested change
| /// Create a Features given a set of flags, in big-endian. This is in byte order from | |
| /// Create a [`Features`] given a set of flags, in big-endian. This is in byte order from |
Downstream projects building Feature<T> are most likely doing so with a big-endian byte array, however only `from_le_bytes` is exposed.
sr-gi
force-pushed
the
20231003-expose-from-be-bytes
branch
from
60607b9
to
2b1d693
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
+ Coverage 89.02% 89.54% +0.51%
==========================================
Files 112 112
Lines 86932 90657 +3725
Branches 86932 90657 +3725
==========================================
+ Hits 77390 81177 +3787
+ Misses 7307 7294 -13
+ Partials 2235 2186 -49
☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Oct 5, 2023
TheBlueMatt
approved these changes
Oct 5, 2023
|
Clippy issue is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream projects building
Feature<T>are most likely doing so with a big-endian byte array, however onlyfrom_le_bytesis exposed.