-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix matching of second-stage HTLC claim in get_htlc_balance #2610
Merged
TheBlueMatt
merged 9 commits into
lightningdevkit:main
from
wpaulino:missing-htlc-claim-balance
Sep 29, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0930be3
Fix matching of second-stage HTLC claim in get_htlc_balance
TheBlueMatt 52d76f9
Add test util to handle bump HTLC events
wpaulino 28f2dac
Add anchors coverage to chanmon_claim_value_coop_close
wpaulino ea4b187
Add anchors coverage to test_claim_value_force_close
wpaulino 898a200
Add anchors coverage to test_balances_on_local_commitment_htlcs
wpaulino 4156d7c
Add anchors coverage to test_revoked_counterparty_commitment_balances
wpaulino fe45af6
Add anchors coverage to test_revoked_counterparty_htlc_tx_balances
wpaulino 4a393ee
Add anchors coverage to test_revoked_counterparty_aggregated_claims
wpaulino fd66a29
Fix wrong node broadcaster in test_yield_anchors_events
wpaulino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be canonical this is a property of the transaction signature bip143 digest algorithm where the sha_single_output is computed from the index of the spent input. This is also true for bip341 digest algorithm, however if transaction digest algorithm computation of sighash flags change in the future, we would have to update this code in consequence (and indeed more complicated sighash flags have been proposed in the past).