Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip keysend feature bit on #2465

Merged

Conversation

alecchendev
Copy link
Contributor

Keysend seems to be the only feature bit that's in the node context and not the init context, so whenever we switched to providing the default init feature bits as our node feature bits, we must've left out keysend!

@TheBlueMatt TheBlueMatt linked an issue Jul 31, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5cddf5e) 90.33% compared to head (7ee90a5) 90.34%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2465   +/-   ##
=======================================
  Coverage   90.33%   90.34%           
=======================================
  Files         106      106           
  Lines       55732    55734    +2     
  Branches    55732    55734    +2     
=======================================
+ Hits        50347    50351    +4     
+ Misses       5385     5383    -2     
Files Changed Coverage Δ
lightning/src/ln/channelmanager.rs 85.71% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit 56fba35 into lightningdevkit:main Jul 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keysend feature not set
5 participants