Require best block timestamp within ChannelManager::new #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM modulo the test failure. |
wpaulino
force-pushed
the
channelmanager-new-highest-seen-timestamp
branch
2 times, most recently
from
aef6ac2
to
554d48f
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01%
==========================================
Files 106 106
Lines 54747 54954 +207
Branches 54747 54954 +207
==========================================
+ Hits 49441 49635 +194
- Misses 5306 5319 +13
☔ View full report in Codecov by Sentry. |
valentinewallace
previously approved these changes
Jun 27, 2023
wpaulino
force-pushed
the
channelmanager-new-highest-seen-timestamp
branch
from
554d48f
to
2eff97c
Compare
|
CI sad. Could this be useful on restart as well, if the node was down for a while? |
|
That should be covered by syncing to the current chain tip. |
wpaulino
force-pushed
the
channelmanager-new-highest-seen-timestamp
branch
from
2eff97c
to
1731b8f
Compare
TheBlueMatt
previously approved these changes
Jun 27, 2023
valentinewallace
previously approved these changes
Jun 27, 2023
tnull
reviewed
Jun 27, 2023
This ensures freshly initialized nodes can proceed to create unexpired invoices without a call to `best_block_updated`, since an invoice's expiration delta is applied to `highest_seen_timestamp`.
wpaulino
dismissed stale reviews from valentinewallace and TheBlueMatt
via
82e0df5
wpaulino
force-pushed
the
channelmanager-new-highest-seen-timestamp
branch
from
1731b8f
to
82e0df5
Compare
tnull
approved these changes
Jun 27, 2023
valentinewallace
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures freshly initialized nodes can proceed to create unexpired invoices without a call to
best_block_updated, since an invoice's expiration delta is applied tohighest_seen_timestamp.Fixes #2345.