Require inbound channels with anchor outputs to be accepted manually #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
force-pushed
the
inbound-anchors-manual-acceptance
branch
from
2329307
to
ed14d0e
Compare
TheBlueMatt
reviewed
Jun 23, 2023
Now that all of the core functionality for anchor outputs has landed, we're ready to remove the config flag that was temporarily hiding it from our API.
wpaulino
force-pushed
the
inbound-anchors-manual-acceptance
branch
from
ed14d0e
to
dece81e
Compare
TheBlueMatt
previously approved these changes
Jun 23, 2023
Since the use of channels with anchor outputs requires a reserve of onchain funds to handle channel force closures, it would be irresponsible to allow a node to accept inbound channel without first consulting such reserves. To allow users to do so, we require such channels be manually accepted.
wpaulino
force-pushed
the
inbound-anchors-manual-acceptance
branch
from
dece81e
to
e6348b8
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
==========================================
+ Coverage 90.30% 90.31% +0.01%
==========================================
Files 106 106
Lines 54900 54948 +48
Branches 54900 54948 +48
==========================================
+ Hits 49576 49628 +52
+ Misses 5324 5320 -4
☔ View full report in Codecov by Sentry. |
TheBlueMatt
previously approved these changes
Jun 24, 2023
wpaulino
dismissed
TheBlueMatt’s stale review
The merge-base changed after approval.
dunxen
previously approved these changes
Jun 24, 2023
| @@ -1100,6 +1100,15 @@ pub fn create_chan_between_nodes_with_value_init<'a, 'b, 'c>(node_a: &Node<'a, ' | |||
| assert_eq!(open_channel_msg.temporary_channel_id, create_chan_id); | |||
| assert_eq!(node_a.node.list_channels().iter().find(|channel| channel.channel_id == create_chan_id).unwrap().user_channel_id, 42); | |||
| node_b.node.handle_open_channel(&node_a.node.get_our_node_id(), &open_channel_msg); | |||
| if node_b.node.get_current_default_configuration().manually_accept_inbound_channels { | |||
There was a problem hiding this comment.
Thanks, I was going to need this anyway for V2 establishment :)
| #[test] | ||
| fn test_inbound_anchors_manual_acceptance() { | ||
| // Tests that we properly limit inbound channels when we have the manual-channel-acceptance | ||
| // flag set and (sometimes) accept channels as 0conf. |
There was a problem hiding this comment.
What conditions correspond with “sometimes” here?
There was a problem hiding this comment.
Ah, I copied another test as a template but forgot to update the comment here. Will fix in a future PR.
dunxen
previously approved these changes
Jun 24, 2023
TheBlueMatt
approved these changes
Jun 24, 2023
TheBlueMatt
previously approved these changes
Jun 24, 2023
wpaulino
dismissed stale reviews from TheBlueMatt and dunxen
The merge-base changed after approval.
|
Oh joy github is broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the use of channels with anchor outputs requires a reserve of onchain funds to handle channel force closures, it would be irresponsible to allow a node to accept inbound channel without first consulting such reserves. To allow users to do so, we require such channels be manually accepted.
Depends on #2361 and #2367.