Fix build on supported platforms due to log breakage
#2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `log` crate decided to break support for rustc 1.48 (Debian bullseye) the day the next release of Debian comes out, obviously before anyone has had a chance to upgrade to the new Debian bookworm (at rust-lang/log#543). Thus, we have to manually pin it back to the previous release. Sadly, the `log` crate is a transitive dependency of `tokio` until 0.20, which requires rustc 1.49. Luckily at least we won't have to deal with this again, as `log` won't be a dependency of ours anymore soon.
TheBlueMatt
force-pushed
the
2023-06-fix-msrv-build
branch
from
20b248c
to
d401848
Compare
dunxen
approved these changes
Jun 12, 2023
wpaulino
approved these changes
Jun 12, 2023
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
=======================================
Coverage 90.48% 90.48%
=======================================
Files 104 104
Lines 53920 53920
Branches 53920 53920
=======================================
Hits 48790 48790
Misses 5130 5130 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
logcrate decided to break support for rustc 1.48 (Debian bullseye) the day the next release of Debian comes out, obviously before anyone has had a chance to upgrade to the new Debian bookworm (at rust-lang/log#543). Thus, we have to manually pin it back to the previous release.Sadly, the
logcrate is a transitive dependency oftokiountil 0.20, which requires rustc 1.49. Luckily at least we won't have to deal with this again, aslogwon't be a dependency of ours anymore soon.