use PrintableString to Display CounterpartyForceClosed peer_msg

[Evanfeenstra]

This addresses #2108

It's a simple wrapper struct to safely print CounterpartyForceClosed peer_msg.

nothin like some Rust on a friday night

[codecov-commenter]

Codecov Report

Patch coverage: 56.52% and project coverage change: -0.01 ⚠️

Comparison is base (217c3e0) 91.32% compared to head (bef56cb) 91.31%.

❗ Current head bef56cb differs from pull request most recent head 315fdf6. Consider uploading reports for the commit 315fdf6 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.01%     
==========================================
  Files         101      101              
  Lines       48791    48846      +55     
  Branches    48791    48846      +55     
==========================================
+ Hits        44558    44606      +48     
- Misses       4233     4240       +7     

Impacted Files	Coverage Δ
lightning/src/util/string.rs	60.86% <25.00%> (-39.14%)	⬇️
lightning/src/util/events.rs	32.39% <50.00%> (+0.86%)	⬆️
lightning/src/ln/channelmanager.rs	89.10% <100.00%> (ø)
lightning/src/ln/functional_tests.rs	98.24% <100.00%> (ø)
lightning/src/ln/payment_tests.rs	97.42% <100.00%> (ø)
lightning/src/ln/reload_tests.rs	95.52% <100.00%> (ø)
lightning/src/ln/reorg_tests.rs	100.00% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs	98.04% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TheBlueMatt]

Thanks for tackling this!

[Evanfeenstra]

Thanks for tackling this!

No problem! Thanks for the suggestions, I implemented them

[Evanfeenstra]

any tips on getting the ubuntu/windows/macos checks to pass?

[valentinewallace]

Basically lgtm, just some nits

[TheBlueMatt]

any tips on getting the ubuntu/windows/macos checks to pass?

Should be fixed for you when you push, it was an MSRV break due to serde being awful.

[jkczyz]

Feel free to squash, IMO.

[Evanfeenstra]

Feel free to squash, IMO.

ok, squashed and re-ordered the util::string file

[TheBlueMatt]

nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.

More importantly, though, please keep your commit titles and messages to around 80 chars long - if you have more information to convey, you should have one line that is the title followed by a blank line and then some number of lines that provide more details.

Other than those looks good.

[jkczyz]

nit: SanitizedString makes it sound like the string inside is already sanitized, but its not, its a SanitizingString or maybe more aptly, Untrusted or PossiblyMalicious String.

Good point. I'd be fine with UntrustedString.

[Evanfeenstra]

ok, renamed to UntrustedString

[TheBlueMatt]

Can you squash the fixup commits so that there aren't later commits fixing code introduced in earlier commits in the same PR? Other than that should be good, thanks!

[Evanfeenstra]

Ok, it's in a single commit. Thanks for all the help yall!