Correct outbound_payment route-fetch calls to pass the hash + ID
#2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Route::get_route_with_id` exists to provide users payment-specific data when fetching a route, however we were failing to call it when we have such info, opting for the simple `get_route` instead. This defeats the purpose of the additional-metadata method, which we swap to using here.
valentinewallace
previously approved these changes
Mar 9, 2023
tnull
previously approved these changes
Mar 9, 2023
jkczyz
reviewed
Mar 9, 2023
arik-so
previously approved these changes
Mar 9, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 101 101
Lines 48887 48888 +1
Branches 48887 48888 +1
=======================================
+ Hits 44557 44559 +2
+ Misses 4330 4329 -1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TheBlueMatt
dismissed stale reviews from arik-so, tnull, and valentinewallace
via
10e6978
|
Added another commit to further simplify the macro. The first commit here will be included in the 0.0.114.0 Java/Ts release, the second will not. |
jkczyz
approved these changes
Mar 9, 2023
valentinewallace
approved these changes
Mar 9, 2023
tnull
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route::get_route_with_idexists to provide users payment-specific data when fetching a route, however we were failing to call it when we have such info, opting for the simpleget_routeinstead. This defeats the purpose of the additional-metadata method, which we swap to using here.