added fn_add_htlc #2042
added fn_add_htlc #2042
Conversation
There was a problem hiding this comment.
Looks good, thanks! Please reword your commit message to describe what the function does in a short (< 80 chars) title and a (80-char-line-wrapped) description that describes why this is useful. It doesn't need to be super detailed, but more than what you have now would be great.
You don't need to open a new PR to change what you have, just force-push the new commit onto the same branch and the PR will update.
Codecov ReportBase: 90.77% // Head: 87.20% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2042 +/- ##
==========================================
- Coverage 90.77% 87.20% -3.58%
==========================================
Files 94 101 +7
Lines 49603 44178 -5425
Branches 49603 44178 -5425
==========================================
- Hits 45028 38525 -6503
- Misses 4575 5653 +1078
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Can you squash the commits down into one commit and wrap the lines so that they aren't longer than 70 chars? See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#rebasing-changes for squashing/rebase instructions. |
which is used by router One would use that function if he would get data from for example c-lightning lightning.readthedocs.io/lightning-listhtlcs.7.html and would like to use that with ldk's router
A possible use case for this function might be if someone would be getting data of htlcs from lightning core via this rpc call: https://lightning.readthedocs.io/lightning-listhtlcs.7.html.