Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outbound payments probe leak #2037

Merged

Conversation

valentinewallace
Copy link
Contributor

Fixes #2036.

Based on #2008.

@valentinewallace valentinewallace added this to the 0.0.114 milestone Feb 15, 2023
@jkczyz jkczyz self-requested a review February 15, 2023 23:02
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 87.21% // Head: 87.02% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (2f14891) compared to base (30b9d9f).
Patch coverage: 92.70% of modified lines in pull request are covered.

❗ Current head 2f14891 differs from pull request most recent head a2b956d. Consider uploading reports for the commit a2b956d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2037      +/-   ##
==========================================
- Coverage   87.21%   87.02%   -0.20%     
==========================================
  Files         100      100              
  Lines       44023    44543     +520     
  Branches    44023    44543     +520     
==========================================
+ Hits        38396    38762     +366     
- Misses       5627     5781     +154     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 85.84% <ø> (ø)
lightning/src/routing/router.rs 92.79% <ø> (ø)
lightning/src/util/events.rs 23.63% <ø> (-0.58%) ⬇️
lightning/src/ln/payment_tests.rs 95.94% <82.05%> (+<0.01%) ⬆️
lightning/src/ln/outbound_payment.rs 80.40% <84.21%> (+0.11%) ⬆️
lightning/src/ln/chanmon_update_fail_tests.rs 97.31% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 88.50% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.29% <100.00%> (+0.01%) ⬆️
lightning/src/ln/monitor_tests.rs 98.73% <100.00%> (ø)
lightning/src/ln/onion_route_tests.rs 95.45% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt
Copy link
Collaborator

Needs rebase now that #2008 landed.

@TheBlueMatt
Copy link
Collaborator

Change LGTM, though.

Previously we had a memory leak where probes would not be removed from
outbound_payments on htlc fail
@TheBlueMatt TheBlueMatt merged commit a170478 into lightningdevkit:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pending outbound probes on resolution
4 participants