Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keys to be unpersisted #1705

Closed
wants to merge 3 commits into from
Closed

Allow keys to be unpersisted #1705

wants to merge 3 commits into from

Commits on Sep 8, 2022

  1. Allow keys to be unpersisted 

    Previously the `KVStorePersister` only allowed to `persist` a
`Writeables` under a given key. However, we may want to be able to
remove this set key after the fact.

Here we therefore extend the trait with a `unpersist` method and implement it
for `FilesystemPersister`.
    @tnull
    tnull committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    261f13d View commit details
    Browse the repository at this point in the history

  2. f Do we really support Windows?

    @tnull
    tnull committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    5b8b518 View commit details
    Browse the repository at this point in the history

  3. Reword FP docs to reflect more general usage 

    Since `FilesystemPersister` is used for different types of `Writeables`,
not only channel data, we can now reword the docs to reflect its more
general use case.
    @tnull
    tnull committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    511434f View commit details
    Browse the repository at this point in the history