Fix wait_for_tx/outpoint exponential backoff #641
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks! Seems like wait_for_outpoint_spend might benefit from the same fix?
| } | ||
|
|
||
| pub(crate) fn wait_for_tx<E: ElectrumApi>(electrs: &E, txid: Txid) { | ||
| let mut tx_res = electrs.transaction_get(&txid); |
There was a problem hiding this comment.
Maybe it's worth to keep the pattern to avoid the unnecessary ping if the result is immediately available.
There was a problem hiding this comment.
Ok. What is the ping for actually?
There was a problem hiding this comment.
See https://docs.rs/electrum-client/latest/electrum_client/trait.ElectrumApi.html#tymethod.ping
ping might trigger electrs to process new data before we actually attempt the lookup.
Backoff wasn't actually working and polling would happen without any delay at all.
joostjager
force-pushed
the
backoff-fix
branch
from
0234637 to
3df1477
Compare
joostjager
changed the title
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
3 participants
Backoff wasn't actually working and polling would happen without any delay at all.