Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Sauron to the new lightningd #95

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

darosior
Copy link
Member

After ElementsProject/lightning#3570 was merged.

I used a higher feerate for HTLC resolution and penalty transaction, as per ElementsProject/lightning#3592. What do you think ?

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #95 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   47.75%   47.75%           
=======================================
  Files          15       15           
  Lines        1734     1734           
=======================================
  Hits          828      828           
  Misses        906      906           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cf4e1...e6288f9. Read the comment docs.

@darosior
Copy link
Member Author

Hi @codecov ! Unfortunately I haven't figured out yet how to make Travis automatically test that !

Otherwise I just added a small README, too.

Copy link
Contributor

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e6288f9

@cdecker
Copy link
Contributor

cdecker commented Mar 30, 2020

Hi @codecov ! Unfortunately I haven't figured out yet how to make Travis automatically test that !

Otherwise I just added a small README, too.

Might be sufficient to just run against testnet, that's what I tried with my bitcoin-cli replacements. It does allow us to test some parts, except sendrawtransaction maybe.

@cdecker cdecker merged commit cdebe82 into lightningd:master Mar 30, 2020
@darosior darosior deleted the sauron_followups branch March 30, 2020 19:58
@darosior
Copy link
Member Author

Might be sufficient to just run against testnet, that's what I tried with my bitcoin-cli replacements. It does allow us to test some parts, except sendrawtransaction maybe.

Used mainnet because of blockchain.info line :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants