Add a feature bit to allow nodes to opt-out of channel updates#218
Closed
Roasbeef wants to merge 2 commits intolightning:masterfrom
Closed
Add a feature bit to allow nodes to opt-out of channel updates#218Roasbeef wants to merge 2 commits intolightning:masterfrom
Roasbeef wants to merge 2 commits intolightning:masterfrom
Conversation
This commit adds a new section to the 7th BOLT document detailing a mechanism that nodes can use to opt-out of dynamic channel updates. Doing so is primarily a bandwidth optimization, as the node is able to only receive announcements for new channels and nodes joining the network, rather than announcements for each channel update within the network.
This commit adds the ability of a node to signal that they don’t wish to receive any dynamic channel updates using an unused feature bit in the init message.
Collaborator
|
Main points from discussion:
So deferring until 1.1... |
Collaborator
|
I see the need to optimize bandwidth, however, if we go down this road, I'd like to broaden the bit to suppress all gossip messages, not just the updates. This could be used by slow/low-bandwidth nodes to designate a single node as source for its gossip data (by turning the bit off for that node) and suppress all other nodes. @rustyrussell this concerns the gossip background noise during operation, not the dump-on-connect, for which we already have bit 3. |
| upon initial connection. | ||
|
|
||
| If a node receives an `init` message with the `no_channel_updates` flag set, | ||
| then the receiving not MUST NOT relay any channel update messages to the |
There was a problem hiding this comment.
Minor typo: "...then the receiving node MUST NOT relay any..."
Collaborator
|
Can we close this PR now that we have |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new section to the 7th BOLT document detailing a
mechanism that nodes can use to opt-out of dynamic channel updates.
Doing so is primarily a bandwidth optimization, as the node is able to
only receive announcements for new channels and nodes joining the
network, rather than announcements for each channel update within the
network.
Additionally, we propose the additional ability of a node to signal that
they don’t wish to receive any dynamic channel updates using an
unused feature bit in the init message.