Skip to content

Conversation

@ekzyis
Copy link
Contributor

@ekzyis ekzyis commented Dec 15, 2025

@t-bast mentioned that #1242 should have cleared the context column of payment_secret in #1307 (comment):

But is this also why var_onion_optin does not have 9 in its context column, even though payment_secret does have 9? Both are assumed bits.

It's simply that when making payment_secret assumed in #1242, the context column wasn't cleared (while it was cleared for other features when they were marked assumed). We can clear the context column for payment_secret to make it more consistent with other assumed features, that would avoid confusion.

This PR clears the context column for ALL assumed bits to avoid confusion.

@t-bast t-bast added the spelling These changes may be merged without additional sign off from the weekly meeting label Dec 19, 2025
@t-bast t-bast merged commit d98366c into lightning:master Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spelling These changes may be merged without additional sign off from the weekly meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants