BOLT 12: clarify that empty offer_chains must be rejected #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
approved these changes
Dec 15, 2025
26 tasks
Collaborator
|
Sure. Tempted to just clarify the reader requirements to " - if the node does not accept invoices for at least one of the That clearly covers this case. |
An offer with offer_chains present but containing zero chain hashes is invalid, as it makes invoice requests impossible—the payer cannot satisfy the requirement to set invreq_chain to "one of offer_chains" when the array is empty. Add explicit requirement for readers to reject such offers, along with rationale and a test vector.
erickcestari
force-pushed
the
offer-chains-with-zero-chain-hash
branch
from
82ee861 to
8eb8740
Compare
Contributor
Author
Updated! It should be less repetitive now. |
t-bast
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An offer with
offer_chainspresent but containing zero chain hashes is invalid, as it makes invoice requests impossible. The payer cannot satisfy the requirement to setinvreq_chainto "one ofoffer_chains" when the array is empty.Add explicit requirement for readers to reject such offers, along with rationale and a test vector.
Closes #1282