-
Notifications
You must be signed in to change notification settings - Fork 55
bLIP-04: update from endorsement to accountable signal #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
carlaKC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a pre-existing issue with one of the markdown links.
Working on a LDK implementation which we can link as reference to fill in the outstanding TODO.
cc: @thomash-acinq
blip-0002.md
Outdated
| | 256/257 | `hosted_channels` | This node accepts requests for hosted channels | IN | | [bLIP 17](./blip-0017.md) | | ||
| | 258/259 | `dns_resolver` | This node accepts DNSSEC proof requests | N | | [bLIP 32](./blip-0032.md) | | ||
| | 260/261 | `htlc_endorsement` | This node forwards experimental htlc endorsement signals | N | | [bLIP 4](./blip-004.md) | | ||
| | 260/261 | `htlc_accountability` | This node forwards experimental htlc accountability signals| N | | [bLIP 4](./blip-004.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-existing: link should be to ./blip-0004.md, might as well fix while we're here!
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Removed the `experiment_start/end` dates. This is done because in the previous iteration with endorsement signaling, the recommendation was for the sender to set it to 1 and that could have had privacy concerns when first deploying given that the default was to downgrade the signal to 0. Now the recommended default for both sending and forwarding nodes is to set `accountable` to 0. Hence, the dates have been removed as nodes can start setting the signal without leaking information about being the sender.
e0f0e60 to
f4298f0
Compare
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Renames the endorsement signal to accountable to match the latest proposal lightning/blips#67
Updates the naming from endorsement to accountability to match the latest state of the proposal to mitigate channel jamming attacks.