Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update datasets tutorial #1569

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Conversation

SauravMaheshkar
Copy link
Collaborator

This PR aims to update and refactor Tutorial 1 "Structure your Input"

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (cbd5495) to head (f932e71).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1569   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files         144      144           
  Lines        6120     6120           
=======================================
  Hits         5007     5007           
  Misses       1113     1113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like it!

What I am most unsure about: Did you try actually feeding a hf_dataloader into the Lightly SSL training scripts? They might be incompatible, as the Lightly SSL training scripts expect a (batch, targets, filenames) dataloader output, which is not provided by huggingface.

docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
@SauravMaheshkar
Copy link
Collaborator Author

g scripts? They might be incompatible, as the Lightly SSL training scripts expect a (batch, targets, filenames) dataloader output, which is not provided by huggingface.

Yes, I've tried it out and it does work with Lightly Training Scripts. The Colab Notebook released with the recent vector index blogpost uses the food101 dataset from the Huggingface for training.

Copy link
Contributor

@MalteEbner MalteEbner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side :)

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all this helpful information! I left a bunch of comments, mostly regarding structure and formatting.

docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two small things left and then we can merge :)

docs/source/tutorials/structure_your_input.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@SauravMaheshkar SauravMaheshkar merged commit 6b7d83d into master Jul 8, 2024
12 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/dataset-tutorial branch July 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants