-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update datasets tutorial #1569
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1569 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 144 144
Lines 6120 6120
=======================================
Hits 5007 5007
Misses 1113 1113 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I like it!
What I am most unsure about: Did you try actually feeding a hf_dataloader
into the Lightly SSL training scripts? They might be incompatible, as the Lightly SSL training scripts expect a (batch, targets, filenames) dataloader output, which is not provided by huggingface.
Co-authored-by: Malte Ebner <[email protected]>
Yes, I've tried it out and it does work with Lightly Training Scripts. The Colab Notebook released with the recent vector index blogpost uses the food101 dataset from the Huggingface for training. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all this helpful information! I left a bunch of comments, mostly regarding structure and formatting.
Co-authored-by: guarin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Two small things left and then we can merge :)
Co-authored-by: guarin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot!
This PR aims to update and refactor Tutorial 1 "Structure your Input"