This repository was archived by the owner on Jan 22, 2026. It is now read-only.
testgen: increase gas price of legacy test transaction#12
Merged
lightclient merged 4 commits intolightclient:mainfrom Jan 3, 2023
Merged
testgen: increase gas price of legacy test transaction#12lightclient merged 4 commits intolightclient:mainfrom
lightclient merged 4 commits intolightclient:mainfrom
Conversation
Besu does not accept legacy transactions with a gasPrice below baseFeePerGas. I think it's reasonable to allow this behavior, and the test should be made to pass by increasing the submitted price.
Collaborator
Author
|
See this comment for information about besu behavior: ethereum/hive#661 |
fjl
added a commit
to fjl/execution-apis
that referenced
this pull request
Jan 3, 2023
lightclient
pushed a commit
to ethereum/execution-apis
that referenced
this pull request
Jan 3, 2023
* tests: refill with lightclient/rpctestgen#12 * tests: refill again to fix getProof issue
lightclient
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
besu does not accept legacy transactions with a gasPrice below
baseFeePerGas. I think it's reasonable to allow this behavior, and the
test should be made to pass by increasing the submitted price.