This repository was archived by the owner on May 25, 2023. It is now read-only.
Make Serdes less confusing#70
Closed
joan38 wants to merge 1 commit into
Closed
Conversation
Open
joan38
force-pushed
the
serde-refactor
branch
3 times, most recently
from
May 3, 2018 16:48
85a6923 to
037719f
Compare
Contributor
Author
|
This is ready to be reviewed @debasishg |
Contributor
|
Please read the notification at the top of README. This library has been accepted for inclusion in to Apache Kafka. It's already there in the trunk and will be released along with the next release of Kafka. Hold on to your PRs and submit them against apache/kafka repo once released. It will be difficult to reconcile if we make changes here. |
3 tasks
Contributor
Author
|
This can now be closed as it's been opened on Kafka's repo with apache/kafka#4963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serdes is confusing IMHO:
Serializer,DeserializerandSerdewhich are not very useful.org.apache.kafka.common.serialization.Serdeand incom.lightbend.kafka.scala.streams.DefaultSerdes, instead we should be having only one place where to find all the Serdes.