Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbuild uses name in duplicates checking, should be moduleName #188

Closed
SethTisue opened this issue Sep 29, 2016 · 3 comments
Closed

dbuild uses name in duplicates checking, should be moduleName #188

SethTisue opened this issue Sep 29, 2016 · 3 comments

Comments

@SethTisue
Copy link
Contributor

SethTisue commented Sep 29, 2016 •
edited
Loading

this came up in the community build, where I couldn't build Cats because dbuild complained that both Cats and macro-compat produced org.typelevel#core (which they don't)

details at typelevel/cats#1396 (I had initially thought the problem was on the Cats side)
@SethTisue SethTisue mentioned this issue Sep 29, 2016
Closed
@dwijnand
Copy link
Contributor

dwijnand commented Sep 29, 2016 •
edited
Loading

Perhaps instead of moduleName it should be whatever becomes the artifactId in the POM.

This would allow, as an example, dbuild to not fail when seeing both a cats-core for JVM and a cats-core for JS, by seeing them as org.typelevel#cats-core_2.11 and org.typelevel#cats-core_sjs0.6_2.11 instead.

cunei pushed a commit to cunei/dbuild that referenced this issue Nov 2, 2016
Look at the artifacts name, rather than the project name, to detect c…
424d2b2 
…ollisions

The artifact names are obtained from "moduleName", which may be different
from the project name. Fixes lightbend-labs#188
@cunei cunei mentioned this issue Nov 4, 2016
Merged
@cunei cunei closed this as completed in 2ad1161 Nov 5, 2016
@SethTisue SethTisue mentioned this issue Nov 29, 2016
Closed
@SethTisue
Copy link
Contributor Author

I opened a separate ticket (#193) on the Scala.js angle here.

@cunei
Copy link

cunei commented Nov 30, 2016

@SethTisue The duplicate checking is technically done, according to the suggestion, so this issue should be solved. I spoke with @dwijnand concerning Scala.js, and the issue there is different (see comment in #193)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SethTisue @dwijnand @cunei