Ability added to provide a custom token factory #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmilos
added a commit
to tmilos/SpBundle
that referenced
this pull request
Jan 18, 2016
Merged
tmilos
added a commit
to tmilos/SpBundle
that referenced
this pull request
Jan 18, 2016
tmilos
added a commit
to tmilos/SpBundle
that referenced
this pull request
Jan 18, 2016
|
Thank you for fixing the failing tests. I was in the process of fixing them :) |
|
Sure, no problem, thank you for contributing. |
|
Btw, feel free to add yourself to the CONTRIBUTORS.md file |
|
Sure, that works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying this bundle and our app requires a specific auth token to be created. This PR adds the ability to provide a custom token factory.